Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 5 Current »

Things to watch out for

  • assume good faith and competence, question with curiosity
  • discuss and iterate on overall design before discussing details in the code
  • if you foresee the review will take multiple phases, announce this to the submitter upfront to set expectations about process
  • review code for style, prefix "nit:" for small style recommendations
  • review the commit message: motivation alongside what was changed
  • check and double-check the release note: user-facing changes must be mentioned, and backward-incompatible change must be highlighted

The human side of things

Intro:

More detailed guidelines / background:

Science:

  • No labels

Copyright (C) Cockroach Labs.
Attention: This documentation is provided on an "as is" basis, without warranties or conditions of any kind, either express or implied, including, without limitation, any warranties or conditions of title, non-infringement, merchantability, or fitness for a particular purpose.